Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreeSides to integer conversion helper in enum #2721

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

obrix
Copy link
Member

@obrix obrix commented Sep 27, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the new behavior (if this is a feature change)?
Add conversion material for integer to ThreeSides and ThreeSides to integer.

Does this PR introduce a breaking change or deprecate an API?
No

@obrix obrix requested a review from annetill September 27, 2023 14:30
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix obrix force-pushed the three_side_enum_enhance branch from 16c27ba to e5ff04a Compare September 27, 2023 15:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 8b73f84 into main Sep 28, 2023
@annetill annetill deleted the three_side_enum_enhance branch September 28, 2023 06:31
olperr1 pushed a commit that referenced this pull request Sep 28, 2023
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
(cherry picked from commit 8b73f84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants